Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10771 )
Change subject: IMPALA-110: Support for multiple DISTINCT ...................................................................... Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/10771/9/be/src/exec/aggregation-node-base.cc File be/src/exec/aggregation-node-base.cc: http://gerrit.cloudera.org:8080/#/c/10771/9/be/src/exec/aggregation-node-base.cc@77 PS9, Line 77: for (auto& agg : aggs_) RETURN_IF_ERROR(agg->Reset(state)); > I think Reset() should be called on the aggregators in aggs_. Done http://gerrit.cloudera.org:8080/#/c/10771/9/be/src/exec/aggregation-node.cc File be/src/exec/aggregation-node.cc: http://gerrit.cloudera.org:8080/#/c/10771/9/be/src/exec/aggregation-node.cc@53 PS9, Line 53: vector<unique_ptr<RowBatch>> mini_batches; : if (!replicate_input_ && num_aggs > 1) { : for (int i = 0; i < num_aggs; ++i) { : > nit: this could be nested in an if (!replicate_input_) Done http://gerrit.cloudera.org:8080/#/c/10771/9/be/src/exec/aggregation-node.cc@77 PS9, Line 77: } > nit: DCHECK_EQ could be placed after the definition of num_tupes, so it cou Done http://gerrit.cloudera.org:8080/#/c/10771/9/be/src/exec/grouping-aggregator.h File be/src/exec/grouping-aggregator.h: http://gerrit.cloudera.org:8080/#/c/10771/9/be/src/exec/grouping-aggregator.h@296 PS9, Line 296: AddBatchStreamin > nit: typo Done http://gerrit.cloudera.org:8080/#/c/10771/9/be/src/exec/streaming-aggregation-node.cc File be/src/exec/streaming-aggregation-node.cc: http://gerrit.cloudera.org:8080/#/c/10771/9/be/src/exec/streaming-aggregation-node.cc@97 PS9, Line 97: vector<unique_ptr<RowBatch>> mini_batches; : if (!replicate_input_ && num_aggs > 1) { : for (int i = 0; i < num_aggs; ++i) { : > nit: can be nested in if (!replicate_input_) Done http://gerrit.cloudera.org:8080/#/c/10771/9/be/src/exec/streaming-aggregation-node.cc@134 PS9, Line 134: ave pr > nit: it doesn't seem necessary to check eos since it will be always true if Done http://gerrit.cloudera.org:8080/#/c/10771/9/be/src/exec/streaming-aggregation-node.cc@143 PS9, Line 143: } > nit: it could be DCHECK(aggs_.size(), num_tuples) if placed few lines later Done -- To view, visit http://gerrit.cloudera.org:8080/10771 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I055402eaef6d81e5f70e850d9f8a621e766830a4 Gerrit-Change-Number: 10771 Gerrit-PatchSet: 10 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 31 Aug 2018 20:36:53 +0000 Gerrit-HasComments: Yes
