Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11280 )
Change subject: IMPALA-7469. Invalidate LocalCatalog cache based on topic updates ...................................................................... Patch Set 7: Code-Review+2 (2 comments) lgtm. feel free to submit after clarifying that flag description or if another round is needed, let me know. http://gerrit.cloudera.org:8080/#/c/11280/5/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/11280/5/be/src/catalog/catalog-server.cc@49 PS5, Line 49: impalads > Yea... maybe the names are not so good. I didn't want to use "v1" and "v2" My suggestion is to make it clear what should be used when. I assume that the user first decides on the impalad setting, then needs to adjust this one accordingly. The rest of the explanations are clear. How about the following: The type of data that the catalog service will publish into the Catalog StateStore topic. In 'full' mode, complete catalog objects are published any time a new version is available. In 'minimal' mode, only a minimal object is published when a new version of a catalog object is available. In 'mixed' mode, both types of topic entries are published. When all impalads are configured with --use_local_catalog disabled (the default), 'full' mode should be used. If all impalads are configured with --use_local_catalog enabled, 'minimal' mode should be used. When some impalads are configured with --use_local_catalog to be disabled, and others are enabled, then 'mixed' mode is required. Feel free to re-arrange and trim. http://gerrit.cloudera.org:8080/#/c/11280/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/11280/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1996 PS5, Line 1996: TCatalogObject objectDesc = Preconditions.checkNotNull(req.object_desc, > turns out I have to remove this so that the fe tests work, since normally d I recall this issue, MPALA-4704 where we now wait until an update is received prior to opening ports. Is it not working in some mode? -- To view, visit http://gerrit.cloudera.org:8080/11280 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I615f9e6bd167b36cd8d93da59426dd6813ae4984 Gerrit-Change-Number: 11280 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Sat, 01 Sep 2018 18:26:37 +0000 Gerrit-HasComments: Yes
