Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 )
Change subject: IMPALA-7521: Speed up sub-second unix time->TimestampValue conversions ...................................................................... Patch Set 16: (6 comments) Thanks for spotting these mistakes! I have changed the Jira id in the commit message, because it turned out that a change of mine (https://gerrit.cloudera.org/#/c/10683/) was merged with the same id (IMPALA-7417) in the past (due to typo). I have created a clone of IMPALA-7417 and changed the commit message to point to the new Jira. http://gerrit.cloudera.org:8080/#/c/11183/14/be/src/benchmarks/convert-timestamp-benchmark.cc File be/src/benchmarks/convert-timestamp-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/11183/14/be/src/benchmarks/convert-timestamp-benchmark.cc@581 PS14, Line 581: TimestampValue sec_split_utc_from_unix_time_micros(const int64_t& unix_time_micros) { : int64_t ts_seconds = unix_time_micro > nit: one line. Here and below, where applicable. Done http://gerrit.cloudera.org:8080/#/c/11183/14/be/src/benchmarks/convert-timestamp-benchmark.cc@875 PS14, Line 875: microsec_data.push_back(unix_time * MICROS_PER_SEC + > The comment is out of date. Done http://gerrit.cloudera.org:8080/#/c/11183/14/be/src/benchmarks/convert-timestamp-benchmark.cc@902 PS14, Line 902: } > The comment is out of date. Done http://gerrit.cloudera.org:8080/#/c/11183/14/be/src/benchmarks/convert-timestamp-benchmark.cc@929 PS14, Line 929: > The comment is out of date. Done http://gerrit.cloudera.org:8080/#/c/11183/14/be/src/benchmarks/convert-timestamp-benchmark.cc@936 PS14, Line 936: _ > nit: extra space Done http://gerrit.cloudera.org:8080/#/c/11183/14/be/src/runtime/timestamp-test.cc File be/src/runtime/timestamp-test.cc: http://gerrit.cloudera.org:8080/#/c/11183/14/be/src/runtime/timestamp-test.cc@280 PS14, Line 280: offsets = {0, > Probably this should be called 'offset_seconds' or just 'offsets' Done -- To view, visit http://gerrit.cloudera.org:8080/11183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I572b5876b979ddae58165bd40d5b008ce9d7a4aa Gerrit-Change-Number: 11183 Gerrit-PatchSet: 16 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 03 Sep 2018 17:40:40 +0000 Gerrit-HasComments: Yes
