Philip Zeyliger has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11384


Change subject: Fix generate_junitxml for python2.6.
......................................................................

Fix generate_junitxml for python2.6.

With python 2.6, the syntax "{}".format(1) doesn't work:

    $docker run centos:6 python -c 'print "{}".format(1)'
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
    ValueError: zero length field name in format

generate_junitxml was using this incantation and failing.

I've updated the syntax to be py2.6-friendly, and tested
it like so:

    $docker run -v $(pwd):/mnt centos:6 bash -c "yum install -y 
python-argparse; /mnt/lib/python/impala_py_lib/jenkins/generate_junitxml.py 
--phase phase --step step --stdout out --stderr err; cat 
/extra_junit_xml_logs/*.xml"
    [output from yum...]
    Installed:
      python-argparse.noarch 0:1.2.1-2.1.el6

    Complete!
    Generated: 
./extra_junit_xml_logs/generate_junitxml.phase.step.20180904_18_04_56.xml
    <?xml version="1.0" ?>
    <testsuites errors="0" failures="0" tests="1" time="0.0">
        <testsuite disabled="0" errors="0" failures="0" file="None" log="None" 
name="generate_junitxml.phase.step" skipped="0" tests="1" time="0" 
timestamp="2018-09-04 18:04:56+00:00" url="None">
            <testcase classname="generate_junitxml.phase" name="step">
                <system-out>
                    out
                </system-out>
                <system-err>
                    err
                </system-err>
            </testcase>
        </testsuite>
    </testsuites>

Change-Id: Ic0c1e837a9ed6c2d59906aed1d1098bde6f5d815
---
M lib/python/impala_py_lib/jenkins/generate_junitxml.py
1 file changed, 10 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/11384/1
--
To view, visit http://gerrit.cloudera.org:8080/11384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0c1e837a9ed6c2d59906aed1d1098bde6f5d815
Gerrit-Change-Number: 11384
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <[email protected]>

Reply via email to