Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11353 )
Change subject: [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path ...................................................................... [diagnostics] Make --minidump_dir consistent with Impala's --minidump_path Currently, the diagnostics script expects a full path to the actual directory to which process minidumps are written. This is however incosistent with Impala's configuration --minidump_path. Impala creates a subdirectory under FLAGS_minidump_path (for ex: <FLAGS_minidump_path>/impalad) to which it writes the minidumps. This commit fixes the diagnostic script input --minidump_dir to be consistent with the above behavior from Impala. It now looks for minidumps under the directory <--minidump_path>/<process-name> The users of this script are expected to fix their input args accordingly. Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Reviewed-on: http://gerrit.cloudera.org:8080/11353 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Bharath Vissapragada <[email protected]> --- M bin/diagnostics/collect_diagnostics.py 1 file changed, 10 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Verified Bharath Vissapragada: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9e59f108a1f29a33768a39d0f4554d96e2dcd381 Gerrit-Change-Number: 11353 Gerrit-PatchSet: 5 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]>
