Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11359 )
Change subject: IMPALA-7203. Support UDFs in CatalogdMetaProvider ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11359/6/common/thrift/Types.thrift File common/thrift/Types.thrift: http://gerrit.cloudera.org:8080/#/c/11359/6/common/thrift/Types.thrift@205 PS6, Line 205: specifier > hmm, by duplicate, do you mean making a new struct? or change the argument This is what I understood from the change here: now, TFunction can be used as a query. So for example, if you want a java udf's for function 'foo' that return strings, you would just specify binary_type and ret_type and the fetch would retrieve the subset that matches. After seeing how this is used in catalogmetaprovider, I see that its just the function name is set and the others are left unset. Perhaps this will clarify it: - change L198 to state that this struct is used to represent functions in the catalog, query plans, and as specifiers to fetch function overloads by name. - state that when used as a specifier, only the name is set (required) and the previously required fields are not used. -- To view, visit http://gerrit.cloudera.org:8080/11359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifef8ece9f214dca9441833b00f65c7c152d0ab53 Gerrit-Change-Number: 11359 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 05 Sep 2018 18:54:31 +0000 Gerrit-HasComments: Yes
