Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11386 )
Change subject: [DOCS] Additional updates to the fine-grained priv ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11386/1/docs/topics/impala_grant.xml File docs/topics/impala_grant.xml: http://gerrit.cloudera.org:8080/#/c/11386/1/docs/topics/impala_grant.xml@93 PS1, Line 93: Impala does not currently support revoking only the <codeph>WITH GRANT OPTION</codeph> : from a privilege previously granted to a role. To remove the <codeph>WITH GRANT : OPTION</codeph>, revoke the privilege and grant it again without the <codeph>WITH GRANT : OPTION</codeph> flag. This is not correct. You cannot revoke a privilege if it has the grant option set to true. If a privilege is granted with grant option, it takes two statements to revoke it. e.g. if: GRANT ALL ON SERVER TO ROLE foo_role; then to remove: REVOKE GRANT OPTION FOR ALL ON SERVER FROM ROLE foo_role; REVOKE ALL ON SERVER FROM ROLE foo_fole; http://gerrit.cloudera.org:8080/#/c/11386/1/docs/topics/impala_revoke.xml File docs/topics/impala_revoke.xml: http://gerrit.cloudera.org:8080/#/c/11386/1/docs/topics/impala_revoke.xml@57 PS1, Line 57: <varname>privilege</varname> The optional "GRANT OPTION FOR" is missing. -- To view, visit http://gerrit.cloudera.org:8080/11386 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I964a34a4a5a94d88bb09f66e7b0d25fe5b4d6d7c Gerrit-Change-Number: 11386 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 05 Sep 2018 20:00:35 +0000 Gerrit-HasComments: Yes
