Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11358 )
Change subject: IMPALA-7510. Support principals/privileges with LocalCatalog ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/11358/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/11358/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@738 PS3, Line 738: > I read this as a bug originally until I saw that newCatalogVersion may be u changed to using a boxed Long which starts as null, and added a comment. lmk if it's better http://gerrit.cloudera.org:8080/#/c/11358/6/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/11358/6/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@235 PS6, Line 235: retried via > nit: pushed from I wonder where my wires got crossed there... http://gerrit.cloudera.org:8080/#/c/11358/6/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@750 PS6, Line 750: sequencer > since its specific to auth, pls call this authSequencer or something like t Done http://gerrit.cloudera.org:8080/#/c/11358/6/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@862 PS6, Line 862: LOG.error("Error adding privilege: ", e); > For the case that we got here via a direct ddl, wouldn't the caller want to yea I found this surprising as well. The weird thing is that in that case it would have succeeded but not be reflected in the local impalad. I'll add a TODO here that this error handling is suspicious, but not sure how to fix it (and it's pre-existing) http://gerrit.cloudera.org:8080/#/c/11358/6/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java File fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java: http://gerrit.cloudera.org:8080/#/c/11358/6/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java@214 PS6, Line 214: // here. > is isReady sufficient here? from catalogmetaprovider, its ready when its ad It might be sufficient (or at least better) to do a sleeping loop checking isReady but would rather defer to a separate patch since it's unrelated (I have a JIRA for waiting properly at startup) -- To view, visit http://gerrit.cloudera.org:8080/11358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iccce5aabdb6afe466fdaeae0fb3700c66e658558 Gerrit-Change-Number: 11358 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 05 Sep 2018 22:30:22 +0000 Gerrit-HasComments: Yes
