Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11379 )
Change subject: IMPALA-6442: Misleading file offset reporting in error messages. ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/11379/2/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/11379/2/be/src/exec/hdfs-parquet-scanner.cc@1215 PS2, Line 1215: int64_t metadata_start = file_len - sizeof(int32_t) - sizeof(PARQUET_VERSION_NUMBER) - line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/11379/2/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/11379/2/tests/query_test/test_scanners.py@406 PS2, Line 406: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/11379/2/tests/query_test/test_scanners.py@406 PS2, Line 406: """ line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/11379/2/tests/query_test/test_scanners.py@407 PS2, Line 407: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/11379/2/tests/query_test/test_scanners.py@408 PS2, Line 408: ; flake8: E703 statement ends with a semicolon http://gerrit.cloudera.org:8080/#/c/11379/2/tests/query_test/test_scanners.py@409 PS2, Line 409: ; flake8: E703 statement ends with a semicolon -- To view, visit http://gerrit.cloudera.org:8080/11379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35235e99ea9ceb0d31961dd3b8069f7194f5a2de Gerrit-Change-Number: 11379 Gerrit-PatchSet: 2 Gerrit-Owner: Yongjun Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Yongjun Zhang <[email protected]> Gerrit-Comment-Date: Thu, 06 Sep 2018 08:45:26 +0000 Gerrit-HasComments: Yes
