Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11393 )
Change subject: IMPALA-7541. Avoid initializing Metrics for IncompleteTables ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11393/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/11393/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1194 PS1, Line 1194: initMetrics(); > Doesn't this reset the metrics even for incremental loads? Also doesn't it ah, indeed you're right, I think I need to find a different way to accomplish this patch. I didn't run tests before posting it for review :) -- To view, visit http://gerrit.cloudera.org:8080/11393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0bcaa9c45a8cf75266d4b7c16cc14f0fd669b92 Gerrit-Change-Number: 11393 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 06 Sep 2018 22:36:55 +0000 Gerrit-HasComments: Yes
