Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11227 )
Change subject: IMPALA-7047. Refreshing partitions should not make an RPC per file ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/11227/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/11227/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1256 PS1, Line 1256: * Updates the file metadata of an unpartitioned HdfsTable. > Maybe we should add that this is optimized for incremental load. (Full load Done http://gerrit.cloudera.org:8080/#/c/11227/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1264 PS1, Line 1264: resetPartitions(); : org.apache.hadoop.hive.metastore.api.Table msTbl = getMetaStoreTable(); : Preconditions.checkNotNull(msTbl); : setPrototypePartition(msTbl.getSd()); : HdfsPartition part = createPartition(msTbl.getSd(), null, new FsPermissionCache()); > ok. Can you add a comment for this? Done http://gerrit.cloudera.org:8080/#/c/11227/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1269 PS1, Line 1269: > ... Done http://gerrit.cloudera.org:8080/#/c/11227/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2068 PS1, Line 2068: refreshedPartition.setFileDescriptors(oldPartition.getFileDescriptors()); > same here, can't we directly call refreshpartitionFileMetadata(oldPartition added same comment as above -- To view, visit http://gerrit.cloudera.org:8080/11227 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2051b96599206164aaa06ecbdf64374c46eda956 Gerrit-Change-Number: 11227 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Sep 2018 01:58:50 +0000 Gerrit-HasComments: Yes
