Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11314 )
Change subject: IMPALA-7074: Update OWNER privilege on CREATE, DROP, and SET OWNER ...................................................................... Patch Set 26: Code-Review+2 (2 comments) couple more nits/clarifications. http://gerrit.cloudera.org:8080/#/c/11314/26/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/11314/26/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1019 PS26, Line 1019: * Sentry refresh. Correct, Impala's view will diverge from Sentry's. However, per my understanding, the situation is worse since Impala will adopt Sentry's view, which may or may not be the same as the HMS view (and may never be in sync due to errors). When this situation comes up, the workaround is to try the operation again as suggested here on L1022. http://gerrit.cloudera.org:8080/#/c/11314/26/tests/authorization/test_owner_privileges.py File tests/authorization/test_owner_privileges.py: http://gerrit.cloudera.org:8080/#/c/11314/26/tests/authorization/test_owner_privileges.py@132 PS26, Line 132: def restart_first_impalad(cls): unused, pls remove. -- To view, visit http://gerrit.cloudera.org:8080/11314 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e09332e007ed5aa6a0840683c879a8295c3d2b0 Gerrit-Change-Number: 11314 Gerrit-PatchSet: 26 Gerrit-Owner: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Sep 2018 16:23:45 +0000 Gerrit-HasComments: Yes
