Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11406 )
Change subject: IMPALA-5031: undefined behavior: codegen signed overflow ...................................................................... Patch Set 1: Do we have test coverage for overflows of these operators. Would be good to test the operators overflowing both in positive and negative directions. I looked in expr-test and didn't really see any direct tests of this behaviour. -- To view, visit http://gerrit.cloudera.org:8080/11406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79ec3a5ed974709e5e47be6b074d39ee89461f7f Gerrit-Change-Number: 11406 Gerrit-PatchSet: 1 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 10 Sep 2018 15:44:54 +0000 Gerrit-HasComments: No
