Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11224 )
Change subject: IMPALA-7448: Invalidate recently unused tables from catalogd ...................................................................... Patch Set 8: Code-Review+2 (4 comments) several small changes: couple of nits, couple of unused python warnings, and a suggestion for an extra precondition. http://gerrit.cloudera.org:8080/#/c/11224/8/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java File fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java: http://gerrit.cloudera.org:8080/#/c/11224/8/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@77 PS8, Line 77: scanning occurred and to proceed nit, simplify: scan happened. http://gerrit.cloudera.org:8080/#/c/11224/8/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@189 PS8, Line 189: returns nit: returned http://gerrit.cloudera.org:8080/#/c/11224/8/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@189 PS8, Line 189: Will continue without " + : "invalidating tables based on memory pressure this time. How about: Table invalidation due to memory pressure was skipped. http://gerrit.cloudera.org:8080/#/c/11224/8/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@193 PS8, Line 193: tenuredGenUsage from the docs, getMemoryUsageAfterGc should be non-null and given that we found the pool on L163, this should also be non-null. add a precondition for this? -- To view, visit http://gerrit.cloudera.org:8080/11224 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib549717abefcffb14d9a3814ee8cf0de8bd49e89 Gerrit-Change-Number: 11224 Gerrit-PatchSet: 8 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 10 Sep 2018 23:47:10 +0000 Gerrit-HasComments: Yes
