Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 )
Change subject: IMPALA-1760: Implement shutdown command ...................................................................... Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/10744/20/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/10744/20/be/src/service/impala-server.h@115 PS20, Line 115: /// learned that the executor was quiescing). > it might be worthwhile to point out explicitly that admission control queui expanded to explain sources of latency http://gerrit.cloudera.org:8080/#/c/10744/20/fe/src/main/java/org/apache/impala/analysis/AdminFnStmt.java File fe/src/main/java/org/apache/impala/analysis/AdminFnStmt.java: http://gerrit.cloudera.org:8080/#/c/10744/20/fe/src/main/java/org/apache/impala/analysis/AdminFnStmt.java@36 PS20, Line 36: * Represents an administrative function call, e.g. ": shutdown()". > it might be helpful to show the optional parameters too in the comment. I slightly modified the example, hopefully that was what you had in mind. http://gerrit.cloudera.org:8080/#/c/10744/20/fe/src/main/java/org/apache/impala/analysis/AdminFnStmt.java@55 PS20, Line 55: private long deadlineSecs_; > why is it that the shutdown deadline can be overridden by the command, but I see the grace period as an implementation detail that we will want to change in the future, whereas the deadline is a policy that we will want to keep exposed. -- To view, visit http://gerrit.cloudera.org:8080/10744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d5606ccfec84db4482c1e7f0f198103aad141a0 Gerrit-Change-Number: 10744 Gerrit-PatchSet: 20 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Tue, 11 Sep 2018 18:12:50 +0000 Gerrit-HasComments: Yes
