Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11431 )
Change subject: IMPALA-7559: Disable stat filtering for UTC-normalized timestamp columns ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11431/2/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/11431/2/be/src/exec/hdfs-parquet-scanner.cc@482 PS2, Line 482: break; > Can you add a note in both places that this appears then just so it's obvio Finally I have moved the code into a separate function. + this block is moved a few lines below to keep the "skip the row group if there are missing fields with min/max conjunct" rule. -- To view, visit http://gerrit.cloudera.org:8080/11431 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4c02230993f2390c03d513f08bae2e9d3d538fa Gerrit-Change-Number: 11431 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 13 Sep 2018 12:20:27 +0000 Gerrit-HasComments: Yes
