Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11183 )
Change subject: IMPALA-7521: Speed up sub-second unix time->TimestampValue conversions ...................................................................... Patch Set 22: Code-Review+2 (2 comments) Thanks for the comments, LL looks much better than ll! Carry +2. http://gerrit.cloudera.org:8080/#/c/11183/21/be/src/benchmarks/convert-timestamp-benchmark.cc File be/src/benchmarks/convert-timestamp-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/11183/21/be/src/benchmarks/convert-timestamp-benchmark.cc@581 PS21, Line 581: 24LL > nitL: if you want to use unsigned, you can use 'ull', also this way it woul Done http://gerrit.cloudera.org:8080/#/c/11183/21/be/src/runtime/timestamp-value.h File be/src/runtime/timestamp-value.h: http://gerrit.cloudera.org:8080/#/c/11183/21/be/src/runtime/timestamp-value.h@188 PS21, Line 188: LL > nit: you could use capital letters, 'LL'. Done -- To view, visit http://gerrit.cloudera.org:8080/11183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I572b5876b979ddae58165bd40d5b008ce9d7a4aa Gerrit-Change-Number: 11183 Gerrit-PatchSet: 22 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 17 Sep 2018 10:34:02 +0000 Gerrit-HasComments: Yes
