Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11450 )

Change subject: IMPALA-7492: Add support for DATE text parser/formatter
......................................................................


Patch Set 2:

(3 comments)

I was curious so I took a quick look over the changes to understand the 
high-level changes, I think this makes a lot of sense to me.

http://gerrit.cloudera.org:8080/#/c/11450/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11450/2//COMMIT_MSG@29
PS2, Line 29: - Added BE-tests for DateParser and DateValue classes.
I didn't see any reason in the code to expect that performance would change, 
but it would be good to do a sanity-test of timestamp parsing performance, e.g. 
measure the time taken to convert a largish table of timestamp strings. I'd 
suggest doing this with mt_dop=1 so that scanner threads don't affect 
measurements.


http://gerrit.cloudera.org:8080/#/c/11450/2/be/src/runtime/date-value.h
File be/src/runtime/date-value.h:

http://gerrit.cloudera.org:8080/#/c/11450/2/be/src/runtime/date-value.h@54
PS2, Line 54:   bool IsValid() const {
We should document the invariant about validity. I.e. that it's possible for an 
"invalid" DateValue to exist.


http://gerrit.cloudera.org:8080/#/c/11450/2/be/src/runtime/datetime-parse-util.h
File be/src/runtime/datetime-parse-util.h:

http://gerrit.cloudera.org:8080/#/c/11450/2/be/src/runtime/datetime-parse-util.h@178
PS2, Line 178:     : year(-1),
We'v generally been directly initializing the members when they're constants.



--
To view, visit http://gerrit.cloudera.org:8080/11450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1eec00f22502c4c67c6807c4b51384419ea8b831
Gerrit-Change-Number: 11450
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 17 Sep 2018 16:18:13 +0000
Gerrit-HasComments: Yes

Reply via email to