Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11461 )
Change subject: IMPALA-7579: use the generic filesystem_client to delete and create files in test_query_profile_contains_all_events. ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/11461/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11461/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-7579: use the generic filesystem_client to delete and create files in test_query_profile_contains_all_events. make this line less verbose... something like "fix S3 file ops in test_query_profile_contains_all_events" http://gerrit.cloudera.org:8080/#/c/11461/1//COMMIT_MSG@11 PS1, Line 11: nit: get rid of extra ws http://gerrit.cloudera.org:8080/#/c/11461/1//COMMIT_MSG@11 PS1, Line 11: is nit: it http://gerrit.cloudera.org:8080/#/c/11461/1/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/11461/1/tests/query_test/test_observability.py@224 PS1, Line 224: tmp is this where the db is created? I thought it was under 'test-warehouse' if using the unique_database fixture, and you use the dir there to add a file, then the fixture should take care of removing that file. you can probably simplify here by removing L225. there might be other helper fns around to get the path given the db name. -- To view, visit http://gerrit.cloudera.org:8080/11461 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c6e0899455dd4e12636b959fab4bde79f02fb95 Gerrit-Change-Number: 11461 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 18 Sep 2018 16:51:28 +0000 Gerrit-HasComments: Yes
