Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11465 )
Change subject: IMPALA-7488: Fix hang in test_cancellation ...................................................................... IMPALA-7488: Fix hang in test_cancellation test_cancellation runs a impala-shell process with a query specified then sends a SIGINT and confirms that the shell cancels the query and exits. The hang was happening because the shell's signal handler was incorrectly using the same Thirft connection when calling Close() as the main shell thread, which is not thread safe. Testing: - Ran test_cancellation in a loop 500 times. Previously the hang would repro about every 10 runs. Change-Id: I9c4b570604f7706712eb8e19b1ce69bf35cf15e2 Reviewed-on: http://gerrit.cloudera.org:8080/11465 Reviewed-by: Impala Public Jenkins <[email protected]> Reviewed-by: Tim Armstrong <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M shell/impala_shell.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified Tim Armstrong: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/11465 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9c4b570604f7706712eb8e19b1ce69bf35cf15e2 Gerrit-Change-Number: 11465 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
