Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11464 )
Change subject: IMPALA-7420: different error code for internal cancellation ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Looks good. can you also update the comments at: request-ranges.h:258 request-ranges.h:525 request-ranges.h:546 http://gerrit.cloudera.org:8080/#/c/11464/2/be/src/runtime/io/request-context.cc File be/src/runtime/io/request-context.cc: http://gerrit.cloudera.org:8080/#/c/11464/2/be/src/runtime/io/request-context.cc@256 PS2, Line 256: CANCELLED nit: CONTEXT_CANCELLED -- To view, visit http://gerrit.cloudera.org:8080/11464 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If25d5b539d68981359e4d881cae7b08728ba2999 Gerrit-Change-Number: 11464 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 19 Sep 2018 18:40:49 +0000 Gerrit-HasComments: Yes
