Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 )
Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC ...................................................................... Patch Set 12: (9 comments) http://gerrit.cloudera.org:8080/#/c/10855/12/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/10855/12/be/src/runtime/coordinator-backend-state.cc@497 PS12, Line 497: last_report_seq_no_ = exec_status.report_seq_no(); > Can you add a CHECK here that it isn't decreasing? It's verified above, but Done. Used a DCHECK instead for documenting the invariant. http://gerrit.cloudera.org:8080/#/c/10855/12/be/src/runtime/coordinator-backend-state.cc@508 PS12, Line 508: lock_guard<SpinLock> l1(exec_summary->lock); > is this critical section extending farther than it needs to? should it end Fixed. http://gerrit.cloudera.org:8080/#/c/10855/12/be/src/runtime/fragment-instance-state.h File be/src/runtime/fragment-instance-state.h: http://gerrit.cloudera.org:8080/#/c/10855/12/be/src/runtime/fragment-instance-state.h@128 PS12, Line 128: int32_t ReportSeqNo() { > nit: maybe rename to AdvanceReportSeqNo or NextReportSeqNo or something so Done http://gerrit.cloudera.org:8080/#/c/10855/12/be/src/runtime/fragment-instance-state.h@178 PS12, Line 178: DFAKE_MUTEX(report_seq_no_lock_); > I think this fake mutex should be held around the whole function that gener Good point. Moved to SendReport() instead. http://gerrit.cloudera.org:8080/#/c/10855/12/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/10855/12/be/src/runtime/query-state.cc@306 PS12, Line 306: REPORT_EXEC_STATUS > hmm, I dont see this one used. did I miss something? Nice catch. I meant to rename this to REPORT_EXEC_STATUS_PROFILE. http://gerrit.cloudera.org:8080/#/c/10855/12/common/protobuf/CMakeLists.txt File common/protobuf/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/10855/12/common/protobuf/CMakeLists.txt@47 PS12, Line 47: KRPC_GENERATE(CONTROL_SVC_PROTO_SRCS CONTROL_SVC_PROTO_HDRS > You could factor out the replication of the protobuf generation by putting Good idea. Adopted something similar to your suggested code. http://gerrit.cloudera.org:8080/#/c/10855/12/common/protobuf/common.proto File common/protobuf/common.proto: http://gerrit.cloudera.org:8080/#/c/10855/12/common/protobuf/common.proto@33 PS12, Line 33: int64 > nit: i think fixed64 is more appropriate for these fields since they dont t Agreed that they don't tend to be small. Does using fixed64 make the encoding slightly faster ? http://gerrit.cloudera.org:8080/#/c/10855/12/tests/custom_cluster/test_rpc_timeout.py File tests/custom_cluster/test_rpc_timeout.py: http://gerrit.cloudera.org:8080/#/c/10855/12/tests/custom_cluster/test_rpc_timeout.py@42 PS12, Line 42: > flake8: E251 unexpected spaces around keyword / parameter equals Done http://gerrit.cloudera.org:8080/#/c/10855/12/tests/custom_cluster/test_rpc_timeout.py@42 PS12, Line 42: > flake8: E251 unexpected spaces around keyword / parameter equals Done -- To view, visit http://gerrit.cloudera.org:8080/10855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7638583b433dcac066b87198e448743d90415ebe Gerrit-Change-Number: 10855 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Michal Ostrowski <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 19 Sep 2018 19:01:20 +0000 Gerrit-HasComments: Yes
