Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11471 )
Change subject: IMPALA-7594: Fix the waiting time in test_automatic_invalidation ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11471/1/tests/custom_cluster/test_automatic_invalidation.py File tests/custom_cluster/test_automatic_invalidation.py: http://gerrit.cloudera.org:8080/#/c/11471/1/tests/custom_cluster/test_automatic_invalidation.py@35 PS1, Line 35: timeout = 20 if IMPALAD_BUILD.runs_slowly() or (not IS_HDFS and not IS_LOCAL) else 10 Basic question, for my understanding. Why does this param depend on the build type? If it is a slow build like ASAN, it takes time for the coordinators to report the usage metrics or something else? Trying to understand where the delay is. http://gerrit.cloudera.org:8080/#/c/11471/1/tests/custom_cluster/test_automatic_invalidation.py@53 PS1, Line 53: self.timeout * 2 qq, 2*timeout because we want to make sure it is invalidated timeout before the next cycle of invalidation kicks in or is it just empirical? -- To view, visit http://gerrit.cloudera.org:8080/11471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb41e615e42712f9f75a4180f55270f8d4159668 Gerrit-Change-Number: 11471 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 19 Sep 2018 20:02:52 +0000 Gerrit-HasComments: Yes
