Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11478 )

Change subject: Mark certain vendored JS/CSS files as "binary" to avoid them 
showing up in "git grep".
......................................................................


Patch Set 4: Code-Review+2

Carrying Tim's +2. Build issue was a rat check for .gitattributes; added it to 
the ignore list as is done for .gitignore.


--
To view, visit http://gerrit.cloudera.org:8080/11478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8e7872e598710f871fec93f44dc0028907bfaf1
Gerrit-Change-Number: 11478
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Thu, 20 Sep 2018 03:55:01 +0000
Gerrit-HasComments: No

Reply via email to