Hello Tim Armstrong, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11444
to look at the new patch set (#4).
Change subject: IMPALA-7556: part 1: handle different file systems via
polymorphism
......................................................................
IMPALA-7556: part 1: handle different file systems via polymorphism
This commit reorganizes some parts of the ScanRange class.
File operations are handled through the abstract FileReader
class. The interface supports positional read that will
be needed by IMPALA-5843. The concrete file operations are
implemented in sub-classes LocalFileReader and
HdfsFileReader.
File reader classes are responsible for setting counters and
metrics related to file operations.
The core logic haven't been changed significantly, but quite
a lot code fragments were relocated.
Testing: Debug exhaustive tests passed
Change-Id: Ia3d3d2d774075008285230606b992603d5be1a82
---
M be/src/runtime/io/CMakeLists.txt
M be/src/runtime/io/disk-io-mgr.h
A be/src/runtime/io/file-reader.cc
A be/src/runtime/io/file-reader.h
A be/src/runtime/io/hdfs-file-reader.cc
A be/src/runtime/io/hdfs-file-reader.h
A be/src/runtime/io/local-file-reader.cc
A be/src/runtime/io/local-file-reader.h
M be/src/runtime/io/request-context.h
M be/src/runtime/io/request-ranges.h
M be/src/runtime/io/scan-range.cc
11 files changed, 742 insertions(+), 398 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/11444/4
--
To view, visit http://gerrit.cloudera.org:8080/11444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3d3d2d774075008285230606b992603d5be1a82
Gerrit-Change-Number: 11444
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
