Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11444 )
Change subject: IMPALA-7556: part 1: handle different file systems via polymorphism ...................................................................... Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/11444/5/be/src/runtime/io/hdfs-file-reader.cc File be/src/runtime/io/hdfs-file-reader.cc: http://gerrit.cloudera.org:8080/#/c/11444/5/be/src/runtime/io/hdfs-file-reader.cc@150 PS5, Line 150: } > Actually the other combination (when status is ok but current_bytes_read is Oh that wasn't clear for me from the comment. That makes more sense. Done. http://gerrit.cloudera.org:8080/#/c/11444/6/be/src/runtime/io/hdfs-file-reader.cc File be/src/runtime/io/hdfs-file-reader.cc: http://gerrit.cloudera.org:8080/#/c/11444/6/be/src/runtime/io/hdfs-file-reader.cc@131 PS6, Line 131: // Retry if: : // - first read was not successful : // and : // - used a borrowed file handle > I find this comment to be a bit redundant, but feel free to keep it if you I'd rather keep it to emphasize the retry logic. http://gerrit.cloudera.org:8080/#/c/11444/6/be/src/runtime/io/local-file-reader.cc File be/src/runtime/io/local-file-reader.cc: http://gerrit.cloudera.org:8080/#/c/11444/6/be/src/runtime/io/local-file-reader.cc@22 PS6, Line 22: #include "runtime/io/request-ranges.h" > Is this header really needed? Removed http://gerrit.cloudera.org:8080/#/c/11444/6/be/src/runtime/io/local-file-reader.cc@24 PS6, Line 24: > Is this header really needed? Removed http://gerrit.cloudera.org:8080/#/c/11444/6/be/src/runtime/io/request-context.h File be/src/runtime/io/request-context.h: http://gerrit.cloudera.org:8080/#/c/11444/6/be/src/runtime/io/request-context.h@188 PS6, Line 188: HdfsFileReader; > Does LocalFileReader actually use RequestContext's private members? Removed http://gerrit.cloudera.org:8080/#/c/11444/6/be/src/runtime/io/request-context.h@189 PS6, Line 189: > I would prefer to remove this friendship if it doesn't complicate code too I'd rather not touch that part of the code to keep this commit focused. http://gerrit.cloudera.org:8080/#/c/11444/6/be/src/runtime/io/request-ranges.h File be/src/runtime/io/request-ranges.h: http://gerrit.cloudera.org:8080/#/c/11444/6/be/src/runtime/io/request-ranges.h@70 PS6, Line 70: HdfsFileReader; > Is this friendship really needed? Removed http://gerrit.cloudera.org:8080/#/c/11444/6/be/src/runtime/io/request-ranges.h@197 PS6, Line 197: > Is this friendship really needed? Removed -- To view, visit http://gerrit.cloudera.org:8080/11444 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d3d2d774075008285230606b992603d5be1a82 Gerrit-Change-Number: 11444 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 20 Sep 2018 16:18:25 +0000 Gerrit-HasComments: Yes
