Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11157 )
Change subject: IMPALA-7349: Add Admission control support for automatically setting per host memory limit for a query ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/11157/8/be/src/runtime/test-env.cc File be/src/runtime/test-env.cc: http://gerrit.cloudera.org:8080/#/c/11157/8/be/src/runtime/test-env.cc@116 PS8, Line 116: int64_t mem_limit = query_options->__isset.mem_limit && query_options->mem_limit > 0 ? > formatting is a bit weird - is this what clang-format did? If so, ok to lea yup thats what the clang-format did -- To view, visit http://gerrit.cloudera.org:8080/11157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifec00141651982f5975803c2165b7d7a10ebeaa6 Gerrit-Change-Number: 11157 Gerrit-PatchSet: 9 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhecht.apa...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 20 Sep 2018 19:10:30 +0000 Gerrit-HasComments: Yes
