Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11376 )
Change subject: IMPALA-7519: Support elliptic curve ssl ciphers ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11376/5/be/src/rpc/thrift-server.cc File be/src/rpc/thrift-server.cc: http://gerrit.cloudera.org:8080/#/c/11376/5/be/src/rpc/thrift-server.cc@368 PS5, Line 368: #ifndef OPENSSL_NO_ECDH > I think this should be outside the ifdef (likely as the first line in the m Done -- To view, visit http://gerrit.cloudera.org:8080/11376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1666ceabec51b425e8a82be1cf519e2ac35fa5a6 Gerrit-Change-Number: 11376 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 21 Sep 2018 16:50:57 +0000 Gerrit-HasComments: Yes
