Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11388 )
Change subject: IMPALA-7527: add fetch-from-catalogd cache info to profile ...................................................................... Patch Set 7: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/11388/7/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/11388/7/be/src/service/client-request-state.h@70 PS7, Line 70: Impala servier maybe say "backend"? Impala server sounds vague. http://gerrit.cloudera.org:8080/#/c/11388/7/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/11388/7/be/src/service/client-request-state.cc@142 PS7, Line 142: TRuntimeProfileNode profile Wondering if a copy here is needed and if this should be made an lvalue ref. Looking at the caller, it looks like result.profile is not used later but RETURN_IF_ERROR((*request_state)->Exec(&result)); copies the 'result' to its internal state. (dangerous since we are using std::move() below) -- To view, visit http://gerrit.cloudera.org:8080/11388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I808d55a225338912ebaebd0cf71c36db944b7276 Gerrit-Change-Number: 11388 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 24 Sep 2018 01:34:08 +0000 Gerrit-HasComments: Yes
