Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11440 )
Change subject: IMPALA-7351: Improve memory estimates for Kudu Scan Nodes ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11440/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java: http://gerrit.cloudera.org:8080/#/c/11440/2/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@284 PS2, Line 284: int perHostScanRanges = (int) Math.ceil(((double) scanRangeSpecs_ > Isn't this formula that takes the number of ranges total and produces the n Done. I guess I wanted to preserve the importance of the context around the difference in how this is used in hdfs vs kudu, but I see how it would make sense have this factored out in the scan node separately. -- To view, visit http://gerrit.cloudera.org:8080/11440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9bb52530271b0bff91311a67d222a2e9fac1229 Gerrit-Change-Number: 11440 Gerrit-PatchSet: 3 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 24 Sep 2018 23:18:43 +0000 Gerrit-HasComments: Yes
