Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11513 )
Change subject: IMPALA-7600: bump mem_limit for test_kudu_scan_mem_usage ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11513/2/testdata/workloads/functional-query/queries/QueryTest/kudu-scan-mem-usage.test File testdata/workloads/functional-query/queries/QueryTest/kudu-scan-mem-usage.test: http://gerrit.cloudera.org:8080/#/c/11513/2/testdata/workloads/functional-query/queries/QueryTest/kudu-scan-mem-usage.test@7 PS2, Line 7: ="6.5mb"; Looks good! I initially though of doing the same, but did not realize we account for unused estimated memory here (https://github.com/apache/impala/blob/e38715e25297cc3643482be04e3b1b273e339b54/be/src/runtime/scanner-mem-limiter.cc#L87) which initially led me to believe that we might still end up more than 1 scanner thread if the first one does not use enough. -- To view, visit http://gerrit.cloudera.org:8080/11513 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d992cc076bc8678089f765bdffe92e877e9d229 Gerrit-Change-Number: 11513 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 26 Sep 2018 00:27:45 +0000 Gerrit-HasComments: Yes
