Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11512 )
Change subject: IMPALA-7606: Fix IllegalStateException in CatalogTableInvalidator ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/11512/2/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java File fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java: http://gerrit.cloudera.org:8080/#/c/11512/2/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@157 PS2, Line 157: NotificationEmitter any thoughts on how to test this? it seemed to pass manual tests, so wondering what went wrong here and if we can guard against it in the future. http://gerrit.cloudera.org:8080/#/c/11512/2/tests/custom_cluster/test_automatic_invalidation.py File tests/custom_cluster/test_automatic_invalidation.py: http://gerrit.cloudera.org:8080/#/c/11512/2/tests/custom_cluster/test_automatic_invalidation.py@81 PS2, Line 81: doesn't nit: don't http://gerrit.cloudera.org:8080/#/c/11512/2/tests/custom_cluster/test_automatic_invalidation.py@81 PS2, Line 81: an nit: a http://gerrit.cloudera.org:8080/#/c/11512/2/tests/custom_cluster/test_automatic_invalidation.py@82 PS2, Line 82: in the nit: for -- To view, visit http://gerrit.cloudera.org:8080/11512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If938a40434b00af516445152f88832ef55d0d0ce Gerrit-Change-Number: 11512 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 26 Sep 2018 00:39:51 +0000 Gerrit-HasComments: Yes
