Attila Jeges has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11450 )

Change subject: IMPALA-7492: Add support for DATE text parser/formatter
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11450/4/be/src/runtime/date-test.cc
File be/src/runtime/date-test.cc:

http://gerrit.cloudera.org:8080/#/c/11450/4/be/src/runtime/date-test.cc@76
PS4, Line 76:     EXPECT_FALSE(dv.IsValid());
> It would be more informative if problematic date was added as message.
Done


http://gerrit.cloudera.org:8080/#/c/11450/4/be/src/runtime/date-value.h
File be/src/runtime/date-value.h:

http://gerrit.cloudera.org:8080/#/c/11450/4/be/src/runtime/date-value.h@61
PS4, Line 61: if
> The valid case could be marked as LIKELY.
Done


http://gerrit.cloudera.org:8080/#/c/11450/4/be/src/runtime/date-value.h@68
PS4, Line 68:   DateValue(int year, int month, int day) : 
days_since_epoch_(INVALID_DAYS_SINCE_EPOCH) {
            :     DCHECK(!IsValid());
            :     // Check year range and whether year-month-day is a valid 
date.
            :     if (LIKELY(year >= MIN_YEAR && year <= MAX_YEAR)) {
            :       // Use CCTZ for validity check.
            :       cctz::civil_day date(year, month, day);
            :       if (LIKELY(year == date.year() && month == date.month() && 
day == date.day())) {
            :         days_since_epoch_ = CalcDaysSinceEpoch(date);
            :         DCHECK(IsValid());
            :       }
            :     }
            :   }
> Can you move this to the .cc? This would mean that CalcDaysSinceEpoch and E
Done



--
To view, visit http://gerrit.cloudera.org:8080/11450
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1eec00f22502c4c67c6807c4b51384419ea8b831
Gerrit-Change-Number: 11450
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Jeges <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Attila Jeges <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 26 Sep 2018 13:43:29 +0000
Gerrit-HasComments: Yes

Reply via email to