Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11490 )
Change subject: Added dumping of minidumps to finalize.sh ...................................................................... Patch Set 6: (6 comments) Build with the latest changes + a patch that causes a minidump to be generated: https://jenkins.impala.io/job/gerrit-verify-dryrun/3219/ You can see the junit symptom here: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/3245/testReport/junit/generate_junitxml/finalize/minidumps/ http://gerrit.cloudera.org:8080/#/c/11490/5/bin/jenkins/finalize.sh File bin/jenkins/finalize.sh: http://gerrit.cloudera.org:8080/#/c/11490/5/bin/jenkins/finalize.sh@36 PS5, Line 36: if [[ $(find $LOGS_DIR -path "*minidumps*" -name "*dmp") ]]; then > See comment on line 41. Done http://gerrit.cloudera.org:8080/#/c/11490/5/bin/jenkins/finalize.sh@38 PS5, Line 38: dump_breakpad_symbols.py -b $IMPALA_HOME/be/build/latest -d $SYM_DIR > Do we want to add the *dumped output as --stderr on these (perhaps limited Done http://gerrit.cloudera.org:8080/#/c/11490/5/bin/jenkins/finalize.sh@39 PS5, Line 39: for minidump in $(find $LOGS_DIR -path "*minidumps*" -name "*dmp"); do > Use $(...) since you use it in line 41. Best to be consistent. Done http://gerrit.cloudera.org:8080/#/c/11490/5/bin/jenkins/finalize.sh@41 PS5, Line 41: ${minidump} $SYM_DIR > ${minidump}_dumped 2> ${minidump}_dumped.log > -path "*minidumps*" -name "*dmp" Done http://gerrit.cloudera.org:8080/#/c/11490/5/bin/jenkins/finalize.sh@43 PS5, Line 43: --error "Minidump generated: $minidump" \ > Is 2> /dev/null too aggressive here? Should we dump it to a log in case the Done http://gerrit.cloudera.org:8080/#/c/11490/5/bin/jenkins/finalize.sh@45 PS5, Line 45: done > Do we keep the *.dmp files? If so, do we want to keep SYM_DIR since maybe i On my local machine, SYM_DIR ends up being ~14GB (because it dumps the symbols for all of the BE test binaries, which we probably don't need but its difficult to determine what is needed for any given crash), so I think the value of keeping it is probably not worth the space. By contrast a single dump file is a few MB, though arguable it would make sense to remove them since they're useless afaik with the symbols. -- To view, visit http://gerrit.cloudera.org:8080/11490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1005378f996c2764012622a16a5d66bc83b6b4a1 Gerrit-Change-Number: 11490 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Wed, 26 Sep 2018 18:26:07 +0000 Gerrit-HasComments: Yes
