Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11520 )
Change subject: IMPALA-7543: Enhance scan ranges to support sub-ranges ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11520/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11520/1//COMMIT_MSG@27 PS1, Line 27: reasds type: reads http://gerrit.cloudera.org:8080/#/c/11520/1/be/src/runtime/io/request-context.cc File be/src/runtime/io/request-context.cc: http://gerrit.cloudera.org:8080/#/c/11520/1/be/src/runtime/io/request-context.cc@429 PS1, Line 429: if (cached_read_succeeded) { Can you add some comments about this path? http://gerrit.cloudera.org:8080/#/c/11520/1/be/src/runtime/io/request-context.cc@485 PS1, Line 485: *needs_buffers = range->external_buffer_tag() == Same as line 429. -- To view, visit http://gerrit.cloudera.org:8080/11520 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea26ba386713990f7671aab5a372cf449b8d51e4 Gerrit-Change-Number: 11520 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 27 Sep 2018 12:34:42 +0000 Gerrit-HasComments: Yes
