Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11535 )
Change subject: IMPALA-6661 Consider NaN values equal for grouping purposes. ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/11535/1/be/src/codegen/codegen-anyval.h File be/src/codegen/codegen-anyval.h: http://gerrit.cloudera.org:8080/#/c/11535/1/be/src/codegen/codegen-anyval.h@230 PS1, Line 230: /// Floating point values may be "NaN". Nominally, NaN != NaN, but for grouping purposes line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/11535/1/be/src/codegen/codegen-anyval.h@235 PS1, Line 235: /// Generically speaking, a canonical form of a value ensusre that all ambiguity is removed line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/11535/1/be/src/codegen/codegen-anyval.cc File be/src/codegen/codegen-anyval.cc: http://gerrit.cloudera.org:8080/#/c/11535/1/be/src/codegen/codegen-anyval.cc@730 PS1, Line 730: llvm::Value* CodegenAnyVal::EqToNativePtr(llvm::Value* native_ptr, bool inclusive_equality) { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/11535/1/be/src/codegen/codegen-anyval.cc@754 PS1, Line 754: llvm::Value *local_is_nan = builder_->CreateFCmpUNO(local_val, local_val, "local_val_is_nan"); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/11535/1/be/src/exec/hash-table.h File be/src/exec/hash-table.h: http://gerrit.cloudera.org:8080/#/c/11535/1/be/src/exec/hash-table.h@463 PS1, Line 463: /// values in 'expr_values' with nullness 'expr_values_null'. INCLUSIVE_EQUALITY broadens line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/11535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I996c4a2e1934fd887046ed0c55457b7285375086 Gerrit-Change-Number: 11535 Gerrit-PatchSet: 1 Gerrit-Owner: Michal Ostrowski <mostr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 27 Sep 2018 17:23:49 +0000 Gerrit-HasComments: Yes
