Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11563 )
Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag ...................................................................... Patch Set 1: Code-Review+1 (3 comments) I would prefer to use a query option for this, but as it would be more complex (thus risky) change, I am ok with the flag too. http://gerrit.cloudera.org:8080/#/c/11563/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11563/1//COMMIT_MSG@12 PS1, Line 12: write the page index. Please mention here too that this is planned to be a temporary feature flag. http://gerrit.cloudera.org:8080/#/c/11563/1/be/src/exec/hdfs-parquet-table-writer.cc File be/src/exec/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/11563/1/be/src/exec/hdfs-parquet-table-writer.cc@1316 PS1, Line 1316: void HdfsParquetTableWriter::ResetColumnWriters() { : for (auto& column : columns_) column->Reset(); : } optional: I am not sure if this worth a separate function. http://gerrit.cloudera.org:8080/#/c/11563/1/tests/custom_cluster/test_parquet_page_index.py File tests/custom_cluster/test_parquet_page_index.py: http://gerrit.cloudera.org:8080/#/c/11563/1/tests/custom_cluster/test_parquet_page_index.py@39 PS1, Line 39: CustomClusterTestSuite Please mention in a comment that this is meant to be a temporary solution until the read path is completed. -- To view, visit http://gerrit.cloudera.org:8080/11563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9994882aa59cbaf3ae464100caa8211598287bc Gerrit-Change-Number: 11563 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 02 Oct 2018 13:26:36 +0000 Gerrit-HasComments: Yes
