Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11528 )
Change subject: Use NDV=1 for a Column with all nulls ...................................................................... Patch Set 10: Code-Review+1 (3 comments) Looks great to me; thanks for all the updates! Vuk--are you planning to take another look? http://gerrit.cloudera.org:8080/#/c/11528/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11528/10//COMMIT_MSG@71 PS10, Line 71: Bug: IMPALA-7310: All-null columns give wrong estimates in planner We almost always put "IMPALA-7310:" in the first line of the commit message ("the subject"). http://gerrit.cloudera.org:8080/#/c/11528/10/fe/src/main/java/org/apache/impala/analysis/SlotRef.java File fe/src/main/java/org/apache/impala/analysis/SlotRef.java: http://gerrit.cloudera.org:8080/#/c/11528/10/fe/src/main/java/org/apache/impala/analysis/SlotRef.java@110 PS10, Line 110: // not zero. Perhaps: "if we don't know the null count (in which case, getNumNulls() returns -1)". I had to look up that -1 is how we expose that. http://gerrit.cloudera.org:8080/#/c/11528/8/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test: http://gerrit.cloudera.org:8080/#/c/11528/8/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test@a986 PS8, Line 986: test -- To view, visit http://gerrit.cloudera.org:8080/11528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife657a43c9cafc451bd12ddf857dcb7169e97459 Gerrit-Change-Number: 11528 Gerrit-PatchSet: 10 Gerrit-Owner: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 02 Oct 2018 20:46:54 +0000 Gerrit-HasComments: Yes