Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 )
Change subject: IMPALA-7484: setIsStraightJoin is wrapped in an else clause. ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/11568/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11568/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-7484: setIsStraightJoin is wrapped in an else clause. Our convention for the commit message is: IMPALA-xxx: Brief description on the issue More detailed description on the issue. What the patch does to fix the issue. Testing: - How you did the testing. http://gerrit.cloudera.org:8080/#/c/11568/2/fe/src/main/java/org/apache/impala/analysis/SelectList.java File fe/src/main/java/org/apache/impala/analysis/SelectList.java: http://gerrit.cloudera.org:8080/#/c/11568/2/fe/src/main/java/org/apache/impala/analysis/SelectList.java@89 PS2, Line 89: else { nit: move L89 to L88 http://gerrit.cloudera.org:8080/#/c/11568/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/11568/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1844 PS2, Line 1844: selectListHintCtx nit: rename to ctx http://gerrit.cloudera.org:8080/#/c/11568/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1847 PS2, Line 1847: "select %sstraight_join%s * from functional.alltypes", prefix, suffix), : selectListHintCtx); nit: fix indentation http://gerrit.cloudera.org:8080/#/c/11568/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1849 PS2, Line 1849: assertTrue(selectListHintCtx.getAnalyzer().isStraightJoin()); We also need another test case where assertFalse(ctx.getAnalyzer().isStraightJoin()) -- To view, visit http://gerrit.cloudera.org:8080/11568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf600ebbfefc7398e0896df143a0ab91545cae04 Gerrit-Change-Number: 11568 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 03 Oct 2018 02:26:17 +0000 Gerrit-HasComments: Yes
