Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11563 )
Change subject: IMPALA-7644: Hide Parquet page index writing with feature flag ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/11563/2/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/11563/2/be/src/common/global-flags.cc@242 PS2, Line 242: DEFINE_bool(enable_parquet_page_index_writing_debug_only, false, "If true, Impala will " > Should this be a hidden flag then? We could also add a suffix similar to di Done http://gerrit.cloudera.org:8080/#/c/11563/2/be/src/exec/hdfs-parquet-table-writer.cc File be/src/exec/hdfs-parquet-table-writer.cc: http://gerrit.cloudera.org:8080/#/c/11563/2/be/src/exec/hdfs-parquet-table-writer.cc@705 PS2, Line 705: for (const DataPage& page : pages_) { > can the page be const&? Done http://gerrit.cloudera.org:8080/#/c/11563/2/tests/custom_cluster/test_parquet_page_index.py File tests/custom_cluster/test_parquet_page_index.py: http://gerrit.cloudera.org:8080/#/c/11563/2/tests/custom_cluster/test_parquet_page_index.py@45 PS2, Line 45: TODO: IMPALA-5843 Once Impala is able to read the page index and also write it by > Can you add the Jira to the comment? Done -- To view, visit http://gerrit.cloudera.org:8080/11563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9994882aa59cbaf3ae464100caa8211598287bc Gerrit-Change-Number: 11563 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 04 Oct 2018 12:09:25 +0000 Gerrit-HasComments: Yes
