Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11565 )
Change subject: IMPALA-7659: Simplify expression to collect NULLs count ...................................................................... Patch Set 5: The change in expression makes sense to me. I think we need someone who knows the planner better to evaluate whether we need more testing here. I suspect that tests will need modification to reflect the behaviour change (otherwise we have a testing gap). -- To view, visit http://gerrit.cloudera.org:8080/11565 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic68f8b4c3756eb1980ce299a602a7d56db1e507a Gerrit-Change-Number: 11565 Gerrit-PatchSet: 5 Gerrit-Owner: [email protected] Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Comment-Date: Thu, 04 Oct 2018 22:46:34 +0000 Gerrit-HasComments: No
