Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11057 )
Change subject: IMPALA-5050: Add support to read TIMESTAMP_MILLIS and TIMESTAMP_MICROS from Parquet ...................................................................... Patch Set 12: (3 comments) A guide to the patch sets since 7: 8: rebase 9: bulk of the changes 10: remove/add some empty lines 11: rebase + integraion of UtcFromUnixTimeMillis() 12: fix for clang tidy issue As the two rebases add some noise to the full 7-12 change, I would look mainly at the 8 - 10 diff. http://gerrit.cloudera.org:8080/#/c/11057/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11057/4//COMMIT_MSG@22 PS4, Line 22: Testing: > I will deal with this in the next commit. Changing the tests to use the fun Done http://gerrit.cloudera.org:8080/#/c/11057/4/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/11057/4/be/src/exec/parquet-column-readers.cc@1686 PS4, Line 1686: case TYPE_DECIMAL: > I tried to rewrite it to use unique_ptr, but the result was not very nice. Oops, this is still not done yet. I will return to this issue. This affects only a small part of the patch, so I think that the rest can be reviewed in the meantime. http://gerrit.cloudera.org:8080/#/c/11057/4/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/11057/4/tests/query_test/test_scanners.py@759 PS4, Line 759: "/test-warehouse/{0}.db/{1}".format(unique_database, "int64_timestamps_dict")) > We probably want a test that CREATE TABLE LIKE PARQUET creates timestamp co It is now tested by using create_table_from_parquet. -- To view, visit http://gerrit.cloudera.org:8080/11057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c7c01fffa31b3d2ca3480adf6ff851137dadac3 Gerrit-Change-Number: 11057 Gerrit-PatchSet: 12 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 09 Oct 2018 20:29:59 +0000 Gerrit-HasComments: Yes
