Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11608 )
Change subject: IMPALA-7597: wraps retries around CatalogMetaProvider ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11608/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11608/2//COMMIT_MSG@18 PS2, Line 18: methods of CatalogMetaProvider with retries/logging. When obtaining I'm confused how this is supposed to work. Don't we need to retry from the "top" of the higher level transaction/operation, not just the individual method call? If we just retry the method call, it's going to just keep on throwing because we are retrying with the original TableMetaRef, no? -- To view, visit http://gerrit.cloudera.org:8080/11608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43a21571d54a7966c5c68bea1fe69dbc62be2a0b Gerrit-Change-Number: 11608 Gerrit-PatchSet: 2 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 09 Oct 2018 20:31:46 +0000 Gerrit-HasComments: Yes
