Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11650 )
Change subject: IMPALA-7272: Fix crash in StringMinMaxFilter ...................................................................... Patch Set 1: (3 comments) The fix makes sense to me. Can you please try the DFAKE_SCOPED_LOCK() suggestion and use a query with multiple joins inside the same fragment to see if you can trigger the crash ? http://gerrit.cloudera.org:8080/#/c/11650/1/be/src/runtime/mem-pool.h File be/src/runtime/mem-pool.h: http://gerrit.cloudera.org:8080/#/c/11650/1/be/src/runtime/mem-pool.h@260 PS1, Line 260: uint8_t* ALWAYS_INLINE Allocate(int64_t size, int alignment) noexcept { May benefit from DFAKE_SCOPED_LOCK(). See https://gerrit.cloudera.org/#/c/10855/15/be/src/runtime/fragment-instance-state.cc@396 Same for other functions. http://gerrit.cloudera.org:8080/#/c/11650/1/be/src/util/min-max-filter.h File be/src/util/min-max-filter.h: http://gerrit.cloudera.org:8080/#/c/11650/1/be/src/util/min-max-filter.h@80 PS1, Line 80: /// Returns a new MinMaxFilter with the given type, allocated from 'pool'. Please add a comment for 'mem_tracker' http://gerrit.cloudera.org:8080/#/c/11650/1/be/src/util/min-max-filter.h@186 PS1, Line 186: MemPool mem_pool_; Please add a comment for it. -- To view, visit http://gerrit.cloudera.org:8080/11650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I751cad7e6b75c9d95d7ad029bbd1e52fe09e8a29 Gerrit-Change-Number: 11650 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Wed, 10 Oct 2018 19:23:38 +0000 Gerrit-HasComments: Yes
