Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11641 )
Change subject: IMPALA-7670: Avoid getting the latest tables in bulkAlterPartitions() ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11641/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11641/1//COMMIT_MSG@11 PS1, Line 11: without locking Doesn't the caller of the bulkAlterPartitions() hold the table lock? For example, in the stack mentioned in the jira, dropStats() takes a table lock before it eventually calls bulkAlterPartitions(). With this lock, is it still possible to have concurrent modifications of the same table? private void dropStats(TDropStatsParams params, TDdlExecResponse resp) throws ImpalaException { Table table = getExistingTable(params.getTable_name().getDb_name(), params.getTable_name().getTable_name()); Preconditions.checkNotNull(table); if (!catalog_.tryLockTable(table)) { <===== throw new InternalException(String.format("Error dropping stats for table %s " + "due to lock contention", table.getFullName())); } -- To view, visit http://gerrit.cloudera.org:8080/11641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ec120f9df64d6e7e7d4978b5e190376721a6897 Gerrit-Change-Number: 11641 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Thu, 11 Oct 2018 01:15:53 +0000 Gerrit-HasComments: Yes
