Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11626 )
Change subject: IMPALA-7677: Fix DCHECK failure in GroupingAggregator ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Not super familiar with the code but the fix makes sense to me. Please feel free to get one more review or I can +2 it too. http://gerrit.cloudera.org:8080/#/c/11626/2/be/src/exec/streaming-aggregation-node.cc File be/src/exec/streaming-aggregation-node.cc: http://gerrit.cloudera.org:8080/#/c/11626/2/be/src/exec/streaming-aggregation-node.cc@176 PS2, Line 176: child_batch_.reset(); Not necessary this change but I wonder if this line is necessary given that we usually do this in Close() ? -- To view, visit http://gerrit.cloudera.org:8080/11626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I851007a60472d0e53081c076c863c866c516677c Gerrit-Change-Number: 11626 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Thu, 11 Oct 2018 07:43:40 +0000 Gerrit-HasComments: Yes
