Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11624 )
Change subject: IMPALA-7554: Update custom cluster tests to have new logs for sentry ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py File tests/authorization/test_owner_privileges.py: http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@139 PS2, Line 139: .format(SENTRY_BASE_LOG_DIR)) > nit: I would add extra indentation for the format() If indented, fails flake8 with: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@160 PS2, Line 160: .format(SENTRY_BASE_LOG_DIR)) > same as line 39 same as above. http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@254 PS2, Line 254: .format(SENTRY_BASE_LOG_DIR)) > same as line 39 same as above. http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@275 PS2, Line 275: .format(SENTRY_BASE_LOG_DIR)) > same as line 39 same as above. http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@331 PS2, Line 331: .format(SENTRY_BASE_LOG_DIR)) > same as line 39 same as above. http://gerrit.cloudera.org:8080/#/c/11624/2/tests/authorization/test_owner_privileges.py@352 PS2, Line 352: .format(SENTRY_BASE_LOG_DIR)) > same as line 39 same as above. -- To view, visit http://gerrit.cloudera.org:8080/11624 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6e538af7fd6e6ea21dc3f4442bdebf3b31558516 Gerrit-Change-Number: 11624 Gerrit-PatchSet: 2 Gerrit-Owner: Adam Holley <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 11 Oct 2018 19:15:49 +0000 Gerrit-HasComments: Yes
