Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 )
Change subject: IMPALA-7213, IMPALA-7241: Port ReportExecStatus() RPC to use KRPC ...................................................................... Patch Set 18: (8 comments) http://gerrit.cloudera.org:8080/#/c/10855/17//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10855/17//COMMIT_MSG@40 PS17, Line 40: 2. Added some targeted test cases for profile serialization failure > nit: long line Done http://gerrit.cloudera.org:8080/#/c/10855/17/be/src/rpc/rpc-mgr.inline.h File be/src/rpc/rpc-mgr.inline.h: http://gerrit.cloudera.org:8080/#/c/10855/17/be/src/rpc/rpc-mgr.inline.h@35 PS17, Line 35: std::unique_ptr<P>* proxy) { > hrm, it still feels like we are going through a lot of gymnastics to avoid OK. Reverted to sharing the connection for now in this patch. The kudu patch (https://gerrit.cloudera.org/#/c/11681/) is already out for review. http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/rpc/thrift-util-test.cc File be/src/rpc/thrift-util-test.cc: http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/rpc/thrift-util-test.cc@58 PS14, Line 58: > Should we add a test for SerializeToString as well? Done http://gerrit.cloudera.org:8080/#/c/10855/17/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/10855/17/be/src/runtime/query-state.cc@356 PS17, Line 356: > should we handle errors like these and log it instead? Yes, while Todd previously commented that this should be a CHECK(), I think it's better to not crash Impala on a non-fatal issue. Admittedly, the system is most likely in a bad state if this fails but not being able to send the profile shouldn't be fatal either. http://gerrit.cloudera.org:8080/#/c/10855/16/be/src/service/control-service.h File be/src/service/control-service.h: http://gerrit.cloudera.org:8080/#/c/10855/16/be/src/service/control-service.h@52 PS16, Line 52: e* > nit: with Done http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/testutil/in-process-servers.cc File be/src/testutil/in-process-servers.cc: http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/testutil/in-process-servers.cc@51 PS14, Line 51: // Thrift server c > can you document the reason here? it was not clear to me as to why only thi Done http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/10855/14/be/src/util/runtime-profile.cc@251 PS14, Line 251: if (UNLIKELY(nodes.size()) == 0) return; > does this only happen when thrift de-serialization fails? Or serialization failure on the executor side. http://gerrit.cloudera.org:8080/#/c/10855/14/common/protobuf/control_service.proto File common/protobuf/control_service.proto: http://gerrit.cloudera.org:8080/#/c/10855/14/common/protobuf/control_service.proto@27 PS14, Line 27: message ParquetDmlStatsPB { > nit: maybe retain the comment in thrift file Done -- To view, visit http://gerrit.cloudera.org:8080/10855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7638583b433dcac066b87198e448743d90415ebe Gerrit-Change-Number: 10855 Gerrit-PatchSet: 18 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Michal Ostrowski <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Sun, 14 Oct 2018 02:21:32 +0000 Gerrit-HasComments: Yes
