Anuj Phadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11540 )
Change subject: IMPALA-7555: Set socket timeout in impala-shell ...................................................................... Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/11540/8/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/11540/8/shell/impala_client.py@265 PS8, Line 265: if self.verbose: > This message seems misleading, given that the client has its own notion of Done http://gerrit.cloudera.org:8080/#/c/11540/8/shell/impala_client.py@266 PS8, Line 266: print_to_stderr('Opened TCP connection to %s:%s' % (self.impalad_host, > "on sockets." Done http://gerrit.cloudera.org:8080/#/c/11540/6/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/11540/6/shell/impala_shell.py@816 PS6, Line 816: raise > I think we should keep this, see my comment elsewhere Done http://gerrit.cloudera.org:8080/#/c/11540/8/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/11540/8/shell/impala_shell.py@1510 PS8, Line 1510: """Replaces variable within the string with their corresponding values using the > nit: indent Done http://gerrit.cloudera.org:8080/#/c/11540/8/shell/impala_shell.py@1540 PS8, Line 1540: def get_var_name(name): > While you're here, "Looks", "Returns" Done http://gerrit.cloudera.org:8080/#/c/11540/6/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/11540/6/tests/shell/test_shell_commandline.py@737 PS6, Line 737: but doing this reliably on different Linux distributions is quite hard. > Where did this go? This test hung forever after I moved the unsetting of timeout before the ping RPC. Checked with Lars and we figured out that we can still recreate this by invoking the impala-shell with the SSL flag. -- To view, visit http://gerrit.cloudera.org:8080/11540 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I130fc47f7a83f591918d6842634b4e5787d00813 Gerrit-Change-Number: 11540 Gerrit-PatchSet: 9 Gerrit-Owner: Anuj Phadke <[email protected]> Gerrit-Reviewer: Anuj Phadke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Comment-Date: Wed, 17 Oct 2018 06:40:41 +0000 Gerrit-HasComments: Yes
