Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11701 )
Change subject: IMPALA-7639: Move concurrent UDF tests to a custom cluster test ...................................................................... Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/11701/1/tests/custom_cluster/test_udf_concurrency.py File tests/custom_cluster/test_udf_concurrency.py: http://gerrit.cloudera.org:8080/#/c/11701/1/tests/custom_cluster/test_udf_concurrency.py@23 PS1, Line 23: from subprocess import call, check_call > flake8: F401 'subprocess.call' imported but unused Done http://gerrit.cloudera.org:8080/#/c/11701/1/tests/custom_cluster/test_udf_concurrency.py@27 PS1, Line 27: from tests.common.test_dimensions import ( > flake8: F401 'tests.common.test_dimensions.create_exec_option_dimension_fro Done http://gerrit.cloudera.org:8080/#/c/11701/1/tests/custom_cluster/test_udf_concurrency.py@27 PS1, Line 27: from tests.common.test_dimensions import ( > flake8: F401 'tests.common.test_dimensions.create_uncompressed_text_dimensi Done http://gerrit.cloudera.org:8080/#/c/11701/1/tests/custom_cluster/test_udf_concurrency.py@27 PS1, Line 27: from tests.common.test_dimensions import ( > flake8: F401 'tests.common.test_dimensions.create_exec_option_dimension' im Done http://gerrit.cloudera.org:8080/#/c/11701/1/tests/custom_cluster/test_udf_concurrency.py@31 PS1, Line 31: from tests.common.test_vector import ImpalaTestDimension > flake8: F401 'tests.common.test_vector.ImpalaTestDimension' imported but un Done http://gerrit.cloudera.org:8080/#/c/11701/1/tests/custom_cluster/test_udf_concurrency.py@37 PS1, Line 37: class TestUdfConcurrency(CustomClusterTestSuite): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/11701/1/tests/custom_cluster/test_udf_concurrency.py@56 PS1, Line 56: a > flake8: E501 line too long (97 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/11701/1/tests/custom_cluster/test_udf_concurrency.py@84 PS1, Line 84: d > flake8: E306 expected 1 blank line before a nested definition, found 0 Done http://gerrit.cloudera.org:8080/#/c/11701/1/tests/custom_cluster/test_udf_concurrency.py@121 PS1, Line 121: ; > flake8: E703 statement ends with a semicolon Done http://gerrit.cloudera.org:8080/#/c/11701/1/tests/custom_cluster/test_udf_concurrency.py@174 PS1, Line 174: d > flake8: E306 expected 1 blank line before a nested definition, found 0 Done http://gerrit.cloudera.org:8080/#/c/11701/1/tests/custom_cluster/test_udf_concurrency.py@194 PS1, Line 194: d > flake8: F841 local variable 'drop_threads' is assigned to but never used Done http://gerrit.cloudera.org:8080/#/c/11701/1/tests/custom_cluster/test_udf_concurrency.py@202 PS1, Line 202: ; > flake8: E703 statement ends with a semicolon Done -- To view, visit http://gerrit.cloudera.org:8080/11701 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f255823167a4dd807a07276f630ef02435900a3 Gerrit-Change-Number: 11701 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 17 Oct 2018 17:30:36 +0000 Gerrit-HasComments: Yes
